Skip to content

fix: 1101 correctifs etape 3 (formattage adresse)#1284

Open
olivier-rabot wants to merge 6 commits intomainfrom
fix/1101-bilan-annees-etape-trois
Open

fix: 1101 correctifs etape 3 (formattage adresse)#1284
olivier-rabot wants to merge 6 commits intomainfrom
fix/1101-bilan-annees-etape-trois

Conversation

@olivier-rabot
Copy link
Copy Markdown
Contributor

@olivier-rabot olivier-rabot commented Apr 21, 2026 •
edited
Loading

Ticket(s) lié(s)

https://jira-mcas.atlassian.net/jira/software/c/projects/VAO/boards/336?selectedIssue=VAO-1194

Description

Correction du problème lié à l'ajout d'un séjour sur l'etape 3. Ajout d'une fonction de formattage de l'adresse.
Activation conditionnelle de certains champs (type deficiences, periode) > non required quand l'agrement est en statut brouillon

Screenshot / liens loom

Check-list

  • Ma branche est rebase sur main
  • Des tests ont été écrits pour tous les endpoints créés ou modifiés
  • Refacto "à la volée" des parties sur lesquelles j'ai codée
  • Plus de console.log
  • J'ai ajouté une validation de schéma sur la route que j'ai ajouté ou modifié
  • J'ai converti les fichiers vue en <script lang="ts">
  • Mon code est en Typescript (autant que possible)

Testing instructions

@revu-bot revu-bot Bot requested a review from revu-bot April 21, 2026 14:22
@olivier-rabot olivier-rabot marked this pull request as ready for review April 22, 2026 12:12
revu-bot
revu-bot reviewed Apr 22, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@revu-bot revu-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review: fix/1101 — Address formatting & step 3 corrections

This PR extracts a normalizeAdresse utility into shared-bridge, fixes a bug where allResults was populated even on failed validations, and adds TypeScript types to several Vue components. The overall direction is good, but there are a few issues worth addressing.

File Lines Severity Issue
shared-bridge/src/utils/normalizeAdresse.ts 3 CRITICAL Null-input type mismatch — function signature says AdresseDto but passes null/undefined through
shared-bridge/src/utils/normalizeAdresse.ts 13–17 IMPORTANT Redundant null-checks inside already-guarded branch
frontend-usagers/…/listeSejours.vue 175–180 IMPORTANT values cast to Record<string, any> defeats the purpose of the typed useForm<SejourFormValues>
frontend-usagers/…/typeDeficiences.vue 51–64 IMPORTANT validationObligatoire prop declared but never used — dead code
frontend-usagers/…/tranchesAge.vue 49–62 IMPORTANT Same requiredUnlessBrouillon wrapper is kept for non-BROUILLON statuses, making the BROUILLON branch redundant with the existing helper

revu-bot
revu-bot reviewed Apr 22, 2026
View reviewed changes
Comment thread packages/shared-bridge/src/utils/normalizeAdresse.ts Outdated
revu-bot
revu-bot reviewed Apr 22, 2026
View reviewed changes
Comment thread packages/shared-bridge/src/utils/normalizeAdresse.ts Outdated
@olivier-rabot olivier-rabot requested a review from achorein April 23, 2026 08:20
achorein
achorein reviewed Apr 23, 2026
View reviewed changes
Comment thread packages/frontend-usagers/src/components/agrement/bilan/hebergements.vue
Comment thread packages/frontend-usagers/src/components/agrement/bilan/sejours.vue
Comment thread packages/frontend-usagers/src/components/agrement/bilan/sejours.vue Outdated
Comment thread packages/shared-bridge/src/utils/normalizeAdresse.ts Outdated
@olivier-rabot olivier-rabot force-pushed the fix/1101-bilan-annees-etape-trois branch from a9c1f71 to 0a80dd5 Compare April 24, 2026 14:25
@olivier-rabot olivier-rabot force-pushed the fix/1101-bilan-annees-etape-trois branch from 0a80dd5 to 23b4903 Compare April 24, 2026 14:28
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 24, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@olivier-rabot olivier-rabot requested a review from achorein April 24, 2026 14:39
@tokenbureau
Copy link
Copy Markdown

tokenbureau Bot commented Apr 24, 2026

🎉 Deployment for commit 23b4903 :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/vao/vao/backend:sha-23b4903f25222441554fe02aedd436f0b86294ac
  • 📦 docker pull harbor.fabrique.social.gouv.fr/vao/vao/cron:sha-23b4903f25222441554fe02aedd436f0b86294ac
  • 📦 docker pull harbor.fabrique.social.gouv.fr/vao/vao/external-api:sha-23b4903f25222441554fe02aedd436f0b86294ac
  • 📦 docker pull harbor.fabrique.social.gouv.fr/vao/vao/frontend-bo:sha-23b4903f25222441554fe02aedd436f0b86294ac
  • 📦 docker pull harbor.fabrique.social.gouv.fr/vao/vao/frontend-usagers:sha-23b4903f25222441554fe02aedd436f0b86294ac
  • 📦 docker pull harbor.fabrique.social.gouv.fr/vao/vao/migrations:sha-23b4903f25222441554fe02aedd436f0b86294ac
  • 📦 docker pull maildev/maildev:2.1.0
Debug

achorein
achorein approved these changes Apr 24, 2026
View reviewed changes
Comment thread packages/frontend-usagers/src/components/agrement/bilan/hebergements.vue
nbJours: parseInt(values.nbJours),
mois: values.periode.map((m) => parseInt(m)),
agrBilanAnnuelId,
mois: values.periode.map((m: string) => parseInt(m)),
Copy link
Copy Markdown
Contributor

@achorein achorein Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
mois: values.periode.map((m: string) => parseInt(m)),
mois: values.periode.map((m: string) => parseInt(m, 10)),

toujours spécifié le radix dans un parseInt !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@revu-bot revu-bot revu-bot left review comments

@achorein achorein achorein approved these changes

@l-scherer l-scherer Awaiting requested review from l-scherer

Assignees

@olivier-rabot olivier-rabot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@olivier-rabot @achorein @l-scherer @revu-bot